Skip to content

fix(review-pr): bump actions/cache to v5.0.5 (Node 24)#218

Merged
derekmisler merged 1 commit into
docker:mainfrom
skykelsey:skykelsey/bump-actions-cache-node24
May 26, 2026
Merged

fix(review-pr): bump actions/cache to v5.0.5 (Node 24)#218
derekmisler merged 1 commit into
docker:mainfrom
skykelsey:skykelsey/bump-actions-cache-node24

Conversation

@skykelsey
Copy link
Copy Markdown
Contributor

@skykelsey skykelsey commented May 26, 2026

Summary

Bumps actions/cache/restore and actions/cache/save from v4.2.0 to v5.0.5 in review-pr/action.yml and review-pr/reply/action.yml. The v5 line of actions/cache is the explicit migration to the Node.js 24 runtime — v4 runs on Node.js 20, which GitHub is deprecating.

Why

Every consumer of cagent-action surfaces this warning on every PR-review run today:

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache/restore@1bd1e32a3bdc45362d1e726936510720a7c30a57, actions/cache/save@1bd1e32a3bdc45362d1e726936510720a7c30a57. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026.

Reference: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Originally observed on docker/data-platform PR #701 but it surfaces on every PR-review run across every consumer.

Compatibility

actions/cache@v5 (release notes):

actions/cache@v5 runs on the Node.js 24 runtime and requires a minimum Actions Runner version of 2.327.1.

GitHub-hosted ubuntu-latest runner is currently at 2.334.0 (well above the floor). No API surface changes between v4 and v5 — the only breaking change is the Node.js 24 runtime requirement.

Changes

All occurrences of actions/cache/restore@1bd1e32a... # v4.2.0 and actions/cache/save@1bd1e32a... # v4.2.0 bumped to @27d5ce7f... # v5.0.5:

File Hits
review-pr/action.yml 4 (lines 142, 181, 198, 785)
review-pr/reply/action.yml 2 (lines 65, 98)

Test plan

  • CI runs PR-review on this PR — the deprecation warning should no longer appear in the log.
  • Verify cache restore/save still hit and miss correctly across a fresh run (a cleared cache should miss; a subsequent run should hit).

Related

  • Originally filed as docker/actions#383 — closed as misdirected; the deprecated pin lives here in cagent-action, not in docker/actions.

🤖 Generated with Claude Code

@skykelsey
fix(review-pr): bump actions/cache restore/save to v5.0.5 (Node 24)
0cf1842 
actions/cache v4.2.0 runs on Node.js 20, which GitHub is forcing to
Node.js 24 by default starting June 2, 2026 and removing entirely on
September 16, 2026. The actions/cache v5.x line was released
specifically to move to the Node.js 24 runtime.

Every consumer of cagent-action surfaces the Node.js 20 deprecation
warning on every PR-review run today; this fix removes it.

Verified:
- actions/cache v5.0.5 requires runner version >= 2.327.1; the
  ubuntu-latest GitHub runner is currently 2.334.0.
- v5 release notes flag the Node.js 24 runtime change as the only
  breaking change for v4 → v5 — no API surface changes.
- All four occurrences in review-pr/action.yml and both occurrences in
  review-pr/reply/action.yml updated.
docker-agent
docker-agent reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

No issues found in the changed code. All six occurrences of actions/cache have been consistently updated from the v4.2.0 SHA (1bd1e32a) to the v5.0.5 SHA (27d5ce7f), SHA pins and version comments are in sync, and the v5 API surface (path, key, restore-keys, cache-hit) is fully compatible with existing usage.

@skykelsey skykelsey marked this pull request as ready for review May 26, 2026 22:28
docker-agent
docker-agent reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR bumps actions/cache/restore and actions/cache/save from v4.2.0 to v5.0.5 across both review-pr/action.yml and review-pr/reply/action.yml. All 6 occurrences were updated consistently to the same SHA (27d5ce7f) with matching # v5.0.5 version comments. No v4 pins remain, no interface changes are introduced, and the migration is straightforward and correct.

@derekmisler derekmisler merged commit b9dd627 into docker:main May 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@docker-agent docker-agent docker-agent left review comments

@derekmisler derekmisler derekmisler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skykelsey @derekmisler @docker-agent